Projects
Leo came in with a review request on LRX-32354, a backfill for new fields in the sales index (PR #123 in hydrogen). Happy to take a look at that one.
The reverse-orphaned-giftcard-redemptions-command (LRX-25469, PR #22607) keeps finding new ways to be interesting. This time it was an out-of-memory issue, which I tracked down and implemented a fix for. I also added a --resume-from flag so the command can pick up from a specific transaction rather than starting over from scratch. Given that full execution runs clock over an hour, that flag is less of a nice-to-have and more of a basic necessity for anything that might hiccup mid-run.
Testing PR #15185 (LRX-31809) against Zhijie's merged product type filter work brought its own set of discoveries. Local testing on nobob ran into some environment issues I had to dig through first, which is always a fun warmup before the real work begins. Once I got past that, sorting by customer_name, user_name, or payment_type_names revealed a genuine bug: walk-in customers and sales with null values sort inconsistently because saleSearchEntity.sortMissingValues() returns nil. That is the kind of edge case that looks fine in the happy path and only shows up when you actually push null data through. I filed LRX-37242 to track the fix and have started implementing it in typey. I also caught that the payment type column was truncating other columns due to excessive width, so a fix for that is going into my branch as well.