Projects
Two PRs moved forward today. I opened PR #1971 for LRX-37242, adding include_deleted to SuggestProductsRequest on the typey side, and reviewed and approved Vicky's PR #6835 for LRX-20844, which fixes the split promo error translation. Clean work on her end, easy approval.
The bigger story today was an architectural dead end. While investigating how to wire up deleted entity filtering to the suggest query, I hit a fundamental problem: deleting an entity removes it from the search index entirely. There is no deleted record to filter on because the record is simply gone. I pulled my findings together, presented them to the team, and we are now discussing what to do next. What stings a little is that there had apparently already been a discussion about not supporting deleted product and customer search, and that context never made it back to me despite my mentioning this work at standup for several days running. A lesson in making sure decisions get surfaced to whoever is doing the work, not just the people who were in the room. For now I have documented the investigation on the ticket and backlogged it. I also picked up LRX-36444, the research ticket around sales being created as pending without attributes, and started poking at it.
Peer Feedback - Youssef
What is Youssef doing well?
When I first joined, Youssef was the first person to reach out. He kept checking in even while Samy was on PTO, making sure I knew who to contact and what came next. Rather than just dropping a message and leaving me to figure it out, he pulled Zhijie and me into a shared call to work through the Graphter ticket together, which made ramp-up feel collaborative instead of isolating. His async technical questions about the createSale mutation response and the cash movement webhook were specific and clearly informed by real research beforehand, which makes those exchanges genuinely useful rather than exploratory.
What should Youssef do more or less of?
After our async exchanges, I rarely hear how things landed. The createSale question, the webhook question: good conversations, and then silence. A quick closing note, something like "confirmed, went with X," would make those threads more valuable for both of us. It keeps the knowledge from getting lost and helps me understand where the work actually went. As Youssef takes on more cross-team coordination, closing that loop consistently will matter more and more.
Peer Feedback - Insaf
What is insaf doing well?
When I left for time off mid-project, I handed Insaf two genuinely tricky CDC stream tasks: migrating the cash_movement type column from tinyint to tinyint(4) so BigQuery would stop misreading it as a boolean, and adding retailer_id hydration to the register_open_sequence stream. He resolved both, along with related pipeline stream updates, a backfill, and null retailer_id filtering during that backfill. Those fixes collectively unblocked the entire Cash Movement reporting pipeline. I came back to a problem that was largely solved rather than one waiting on me, which is exactly what you hope for when you hand off work.
What should insaf do more or less of?
The day we had the Cash Movement Report onboarding scheduled, Insaf messaged at 2pm to push it to the next day because another task had come up. That kind of conflict is completely normal, but flagging it earlier in the day would let the other person redirect their afternoon rather than holding it open. As Insaf takes on more independent ownership of work, getting ahead of scheduling friction early will make cross-team coordination a lot smoother for everyone involved.
Peer Feedback - Wasif
What is wasif doing well?
When I asked Wasif if he had time to chat about BigQuery, his response was immediate: "swing by my desk anytime." What impressed me more was what he had ready when I got there. Without being prompted, he pulled up two relevant PRs from reporting-reservoir and sql2bq, the repo itself, the Reporting Glossary, and the Reporting Development wiki page, and walked me through all of it. That combination of genuine availability and showing up to the conversation already armed with the right resources made the session far more useful than I anticipated. Working on the Cash Movement Report, having someone like that across the table saves real time.
What should wasif do more or less of?
The institutional knowledge Wasif shared with me surfaced only because I happened to walk over and ask. The links, the context around BigQuery pipelines, the sql2bq setup: all of it was exactly what I needed, but none of it was findable without knowing to ask him directly. Posting that kind of material in a team channel or adding it to a shared wiki page would let the whole team benefit without needing to know the right question. He clearly has both the knowledge and the instinct to share it. Building the habit of reaching a wider audience would multiply the impact considerably.