Projects
I had a busy review day. Zhijie's LRX-18460 work on register performance with large sales (PR #6855) earned some blocking comments from me. Large sale performance is exactly the kind of thing that looks fine until it isn't, and getting those concerns on the table early is worth the friction. Leo had two PRs up: LRX-36305 targeting database lock timing to resolve API latency in /api/register_sales (PR #22606) got non-blocking feedback, and LRX-37923 to resolve payment_type_names from the swiper instead of stale vend tables (PR #125) got a look as well. The vend table staleness issue is one of those slow-burn problems that causes more confusion than it deserves, so that fix is welcome.
On my own work, I merged PR #15546 for LRX-37483, the sale total filter edge cases and deleted product search fix. The locale number formatting rabbit hole is finally closed. I also picked up LRX-36444, which is a research ticket investigating why sales are being created as pending without attributes. Root cause is still TBD, but it's the kind of mystery that tends to have an embarrassingly specific trigger once you find it.
The Raygun ping from last Friday on the Cash Movement Report turned into something concrete. I traced it to an apostrophe in the note filter field breaking the BigQuery SEARCH function, which treats certain characters as reserved. Created LRX-38120 to track it and added it to the backlog. It's a classic input sanitization gap, and the fix should be straightforward once we get to it.
Team
The deadline to submit AI ideas is Thursday. I'm considering putting something together around AI governance, which feels like a space where someone should be thinking carefully and proactively rather than reactively.
External Requests
Reviewed PR #6856 for LSPAY-39671, which adds the lspCashDiscount property to the total in webregister. Cross-team review work, keeping the lines open with the payments side.